Re: errbacktrace
Alvaro Herrera <alvherre@2ndquadrant.com>
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Dmitry Dolgov <9erthalion6@gmail.com>, Thomas Munro <thomas.munro@gmail.com>
Date: 2019-08-13T13:24:13Z
Lists: pgsql-hackers
On 2019-Aug-13, Peter Eisentraut wrote: > I have changed the configuration setting to backtrace_functions plural, > so that you can debug more than one location at once. I had originally > wanted to do that but using existing functions like > SplitIdentifierString() resulted in lots of complications with error > handling (inside error handling!). So here I just hand-coded the list > splitting. Seems simple enough. Hmm ... but is that the natural way to write this? I would have thought you'd split the list at config-read time (the assign hook for the GUC) and turn it into a List of simple strings. Then you don't have to loop strtok() on each errfinish(). -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Remove debugging aid
- 45ff049e288b 13.0 landed