Horton

Re: Refactoring code stripping trailing \n and \r from strings

Bruce Momjian <bruce@momjian.us>

View thread View on postgr.es
From: Bruce Momjian <bruce@momjian.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-08-06T19:10:33Z
Lists: pgsql-hackers 
On Thu, Aug  1, 2019 at 12:18:20PM +0900, Michael Paquier wrote:
> Hi Tom,
> 
> b654714 has reworked the way we handle removal of CLRF for several
> code paths, and has repeated the same code patterns to do that in 8
> different places.  Could it make sense to refactor things as per the
> attached with a new routine in common/string.c?

Yes, I think this is a good idea.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +

Commits

  1. Refactor logic to remove trailing CR/LF characters from strings