Horton

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Stephen Frost <sfrost@snowman.net>
Cc: Ian Barwick <ian.barwick@2ndquadrant.com>, Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, Amit Kapila <amit.kapila16@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2019-08-06T05:05:26Z
Lists: pgsql-hackers 
On Mon, Aug 05, 2019 at 10:16:16PM -0400, Stephen Frost wrote:
> * Ian Barwick (ian.barwick@2ndquadrant.com) wrote:
>> On 8/6/19 9:52 AM, Stephen Frost wrote:> Greetings,
>>> * Tom Lane (tgl@sss.pgh.pa.us) wrote:
>>>> Concretely, how about the attached?
>>>>
>>>> (Digging around in config.sgml, I found that last-one-wins is stated,
>>>> but only in the context of one include file overriding another.
>>>> That's not *directly* a statement about what happens within a single
>>>> file, and it's in a different subsection anyway, so repeating the
>>>> info in 19.1.2 doesn't seem unreasonable.)
>>>
>>> Agreed.
>> 
>> +1.

I have read the latest patch from Tom and I have a suggestion about
this part:
+     and its settings take effect in the same way.  Settings
+     in <filename>postgresql.auto.conf</filename> override those
+     in <filename>postgresql.conf</filename>.

It seems to me that we should mention included files here, as any
settings in postgresql.auto.conf override these as well.
--
Michael

Commits

  1. Doc: improve documentation about postgresql.auto.conf.

  2. Fix ALTER SYSTEM to cope with duplicate entries in postgresql.auto.conf.