Re: concerns around pg_lsn

On Thu, Aug 01, 2019 at 11:14:32AM +0530, Jeevan Ladhe wrote:
> Sure, agree, it makes sense to address float8in_internal_opt_error(),
> there might be more occurrences of such instances in other functions
> as well. I think if we agree, as and when encounter them while touching
> those areas we should fix them.

I have spotted a third area within make_result_opt_error in numeric.c
which could gain readability by initializing have_error if the pointer
is defined.

> I will further check if by mistake any further commits have removed
> references to assignments from float8in_internal_opt_error(),
> evaluate it, and set out a patch.

Thanks, Jeevan!
--
Michael