Re: idea: log_statement_sample_rate - bottom limit for sampling

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>, Pavel Stehule <pavel.stehule@gmail.com>, Adrien Nayrat <adrien.nayrat@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2019-07-31T01:40:40Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Revert "Add log_statement_sample_rate parameter"
- 75506195da81 13.0 landed
- d5f53a8e26ca 12.0 landed
Revert "Silence compiler warning"
- 4f9ed8f3c5ef 13.0 landed
- d8453ccfbfd6 12.0 landed

On Tue, Jul 30, 2019 at 03:43:58PM -0400, Tom Lane wrote:
> Well, we do not need to have a backwards-compatibility problem
> here, because we have yet to release a version containing
> log_statement_sample_rate.  I do not think it's too late to decide
> that v12's semantics for that are broken, and either revert that
> patch in v12, or back-patch a fix to make it match this idea.

With my RTM hat on, if we think that the current semantics of
log_statement_sample_rate are broken and need a redesign, then I would
take the safest path and just revert the original patch in v12, and
finally make sure that it brews correctly for v13.  We are in beta2
and close to a beta3, so redesigning things at this stage on a stable
branch sounds wrong.
--
Michael