Horton

Re: BUG #15932: Module passwordcheck doesn't reference previous hooks

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: rafaelthca@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2019-07-30T02:24:20Z
Lists: pgsql-bugs

Attachments

On Mon, Jul 29, 2019 at 03:56:35PM +0000, PG Bug reporting form wrote:
> Module passwordcheck doesn't reference (thus, doesn't call) previous
> hooks:
> 
> https://github.com/postgres/postgres/blob/master/contrib/passwordcheck/passwordcheck.c#L133
> 
> As a result, if passwordcheck is used hook check_password_hook becomes
> useless.

So, it would erase the trace of previous hooks if loaded last.
passwordcheck holds value as an example of use for some hooks, and
examples should be a good students, so I agree to do better and fix
that.  The attached patch does the work, what do you think about it?
--
Michael

Commits

  1. Fix handling of previous password hooks in passwordcheck