Horton

Re: Optimization of some jsonb functions

Joe Nelson <joe@begriffs.com>

View thread View on postgr.es
From: Joe Nelson <joe@begriffs.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: David Steele <david@pgmasters.net>, Andrew Dunstan <andrew.dunstan@2ndquadrant.com>, Nikita Glukhov <n.gluhov@postgrespro.ru>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2019-07-26T19:34:22Z
Lists: pgsql-hackers

Attachments

Thomas Munro wrote:
> This doesn't apply -- to attract reviewers, could we please have a rebase?

To help the review go forward, I have rebased the patch on 27cd521e6e.
It passes `make check` for me, but that's as far as I've verified the
correctness.

I squashed the changes into a single patch, sorry if that makes it
harder to review than the original set of five patch files...

--
Joe Nelson      https://begriffs.com

Commits

  1. Split out code into new getKeyJsonValueFromContainer()

  2. Optimize get_jsonb_path_all avoiding an iterator

  3. Refactor code into new JsonbValueAsText, and use it more