Horton

Re: [PATCH] minor bugfix for pg_basebackup (9.6 ~ )

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Ian Barwick <ian.barwick@2ndquadrant.com>, Sergei Kornilov <sk@zsrv.org>, Pgsql Hackers <pgsql-hackers@postgresql.org>
Date: 2019-07-24T23:53:02Z
Lists: pgsql-hackers 
On Wed, Jul 24, 2019 at 11:23:30AM -0400, Alvaro Herrera wrote:
> Heh, yesterday I revised the original patch as attached and was about to
> push when the bell rang.  I like this one because it keeps the comment
> to one line and it mentions the function name in charge of the
> validation (useful for grepping later on).  It's a bit laconic because
> of the long function name and the desire to keep it to one line, but it
> seems sufficient to me.

Looks fine to me.  A nit: addition of braces for the if block.  Even
if that a one-liner, there is a comment so I think that this makes the
code more readable.
--
Michael

Commits

  1. Don't uselessly escape a string that doesn't need escaping

  2. pg_basebackup: Add --slot option