Horton

Re: Compiler warnings with MinGW

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Magnus Hagander <magnus@hagander.net>
Date: 2019-07-20T09:19:34Z
Lists: pgsql-hackers 
On Fri, Jul 19, 2019 at 08:41:28AM -0400, Andrew Dunstan wrote:
> On 7/19/19 1:08 AM, Michael Paquier wrote:
>> The second one is rather obvious to fix, because we don't care about
>> the file mode on Windows, so the attached should do the work.  I am
>> actually surprised that the Visual Studio compilers don't complain
>> about that, but let's fix it.
>>
>> Thoughts?
> 
> +1.

Just wanted to double-check something.  We usually don't bother
back-patching warning fixes like this one, right?
--
Michael

Commits

  1. Remove mingwcompat.c

  2. Fix compilation warning of pg_basebackup with MinGW