Horton

Re: Custom table AMs need to include heapam.h because of BulkInsertState

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: David Rowley <david.rowley@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>, Robert Haas <robertmhaas@gmail.com>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-07-16T09:44:11Z
Lists: pgsql-hackers 
Hi David,

On Wed, Jul 10, 2019 at 09:40:59PM +1200, David Rowley wrote:
> On Wed, 3 Jul 2019 at 19:35, Michael Paquier <michael@paquier.xyz> wrote:
>> This has been reverted as of f5db56f, still it seems to me that this
>> was moving in the right direction.
> 
> I've pushed this again, this time with the cleanup code done in the
> right order. 

I have spent some time lately analyzing f7c830f as I was curious about
the logic behind it, and FWIW the result looks good.  Thanks!
--
Michael

Commits

  1. Fix missing calls to table_finish_bulk_insert during COPY, take 2

  2. Fix missing call to table_finish_bulk_insert during COPY