Horton

Re: BUG #15899: Valgrind detects errors on create gist index

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Alexander Lakhin <exclusion@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Date: 2019-07-10T07:02:19Z
Lists: pgsql-bugs 
On Tue, Jul 09, 2019 at 01:43:41PM +0900, Michael Paquier wrote:
> Regarding the zero-allocation, we have gistLoadNodeBuffer() loading 
> directly the block's contents from a temporary file after allocating a
> page, but gistPushItupToNodeBuffer() justifies that as a cheap
> insurance.  So that's good for me.  Do others have objections or extra
> thoughts?  This comes from 1d27dcf, so this should go all the way down.

Tested and committed down to 9.4.
--
Michael

Commits

  1. Fix variable initialization when using buffering build with GiST