Horton

Thread

Commits

  1. Remove unused variable in statext_mcv_serialize()

  1. mcv compiler warning

    Jeff Janes <jeff.janes@gmail.com> — 2019-07-05T14:13:25Z

    One of the recent mcv commits introduced an unused variable warning.

mcv.c: In function 'statext_mcv_serialize':
mcv.c:914:7: warning: unused variable 'itemlen' [-Wunused-variable]
   int   itemlen = ITEM_SIZE(dim);

The attached fixes it.

Cheers,

Jeff

  2. Re: mcv compiler warning

    Tomas Vondra <tomas.vondra@2ndquadrant.com> — 2019-07-05T15:06:12Z

    On Fri, Jul 05, 2019 at 10:13:25AM -0400, Jeff Janes wrote:
>One of the recent mcv commits introduced an unused variable warning.
>
>mcv.c: In function 'statext_mcv_serialize':
>mcv.c:914:7: warning: unused variable 'itemlen' [-Wunused-variable]
>   int   itemlen = ITEM_SIZE(dim);
>
>The attached fixes it.
>

Thanks.

I think I'll just get rid of the variable entirely, and will just call
the macro from the assert directly. The variable used to be referenced
on multiple places, but that changed during the serialization code
reworks.


regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services