Horton

Re: check_recovery_target_lsn() does a PG_CATCH without a throw

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2019-06-30T12:35:52Z
Lists: pgsql-hackers 
On Sun, Jun 30, 2019 at 11:06:58AM +0200, Peter Eisentraut wrote:
> I ended up rewriting this by extracting the parsing code into
> pg_lsn_in_internal() and having both pg_lsn_in() and
> check_recovery_target_lsn() calling it.  This mirrors similar
> arrangements in float.c

The refactoring looks good to me (including what you have just fixed
with PG_RETURN_LSN).  Thanks for considering it.
--
Michael

Commits

  1. Don't call data type input functions in GUC check hooks