Re: Superfluous libpq-be.h include in GSSAPI code

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Daniel Gustafsson <daniel@yesql.se>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-06-29T02:23:06Z
Lists: pgsql-hackers
On Fri, Jun 28, 2019 at 08:47:33PM +0200, Julien Rouhaud wrote:
> On Fri, Jun 28, 2019 at 4:37 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>> backend/libpq/be-secure-gssapi.c is including both libpq-be.h and libpq.h,
>> which makes libpq-be.h superfluous as it gets included via libpq.h.  The
>> attached patch removes the inclusion of libpq-be.h to make be-secure-gssapi.c
>> behave like other files which need both headers.
> 
> LGTM.

Thanks, committed.  I looked at the area in case but did not notice
anything else strange.

(We have in hba.h a kludge with hbaPort to avoid including libpq-be.h,
I got to wonder if we could do something about that..)
--
Michael

Commits

  1. Remove unnecessary header from be-secure-gssapi.c