Horton

Re: BUG #15724: Can't create foreign table as partition

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Pavan Deolasee <pavan.deolasee@gmail.com>, stepya@ukr.net, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Date: 2019-06-27T16:33:32Z
Lists: pgsql-bugs 
On 2019-Jun-26, Amit Langote wrote:

> On Tue, Jun 25, 2019 at 9:57 PM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:

> > BTW I'm now thinking that those ERRCODE_INVALID_OBJECT_DEFINITION codes
> > are not really the correct ones; I mean, it would be the right one to
> > use for the unexpected relkind condition, but for the other cases I
> > think we should use ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE instead.
> 
> Agreed.

I had second thoughts about this one -- ERRCODE_WRONG_OBJECT_TYPE seems
more appropriate, so I used that.

I also tweaked Fujita-san's recently committed documentation addition.

Pushed to 11 and master.  Thanks!

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Fix partitioned index creation with foreign partitions

  2. Doc: Update documentation on partitioning vs. foreign tables.