Horton

Thread

Commits

  1. Remove remaining traces of Rand_OpenSSL() from the tree

  1. Useless configure checks for RAND_OpenSSL (HAVE_RAND_OPENSSL)

    Michael Paquier <michael@paquier.xyz> — 2019-06-26T14:25:44Z

    Hi all,

We have been using RAND_OpenSSL(), a function new as of OpenSSL 1.1.0
in pgcrypto until fe0a0b5 which has removed the last traces of the
function in the tree.  We still have a configure check for it and the
related compilation flag in pg_config.h.in, and both are now useless.

Any objections to the cleanup done in the attached patch?

Thanks,
--
Michael

  2. Re: Useless configure checks for RAND_OpenSSL (HAVE_RAND_OPENSSL)

    Daniel Gustafsson <daniel@yesql.se> — 2019-06-26T14:35:43Z

    > On 26 Jun 2019, at 16:25, Michael Paquier <michael@paquier.xyz> wrote:

> Any objections to the cleanup done in the attached patch?

None, LGTM.

cheers ./daniel

  3. Re: Useless configure checks for RAND_OpenSSL (HAVE_RAND_OPENSSL)

    Tom Lane <tgl@sss.pgh.pa.us> — 2019-06-26T14:40:19Z

    Michael Paquier <michael@paquier.xyz> writes:
> We have been using RAND_OpenSSL(), a function new as of OpenSSL 1.1.0
> in pgcrypto until fe0a0b5 which has removed the last traces of the
> function in the tree.  We still have a configure check for it and the
> related compilation flag in pg_config.h.in, and both are now useless.

> Any objections to the cleanup done in the attached patch?

+1, fewer configure checks always better.  I don't see any other
references to RAND_OpenSSL either.

			regards, tom lane

  4. Re: Useless configure checks for RAND_OpenSSL (HAVE_RAND_OPENSSL)

    Michael Paquier <michael@paquier.xyz> — 2019-06-26T23:36:25Z

    On Wed, Jun 26, 2019 at 04:35:43PM +0200, Daniel Gustafsson wrote:
> None, LGTM.

Thanks, committed.
--
Michael