Horton

Re: BUG #15789: libpq compilation with OpenSSL 1.1.1b fails on Windows with Visual Studio 2017

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>, Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>, serpashk@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2019-06-25T13:52:43Z
Lists: pgsql-bugs 
On 2019-Jun-25, Michael Paquier wrote:

> Attached is an updated version which I would be fine to commit.  I
> have tested it with compilation linking to OpenSSL 1.0.2 and 1.1.0 on
> Win32 and the build is able to complete.  This applies on HEAD only,
> where I have run all my tests.  The patch is properly indented.

In sub GenerateFiles, I would move the stanza for ->{openssl} next to
the one for ->{gss} and keep the simpler lines all together (your patch
leaves ->{nls} as a separate item, which is aesthetically unpleasing).

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Add support for OpenSSL 1.1.0 and newer versions in MSVC scripts