Horton

Re: check_recovery_target_lsn() does a PG_CATCH without a throw

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2019-06-25T01:07:50Z
Lists: pgsql-hackers 
On Mon, Jun 24, 2019 at 11:27:26PM +0200, Peter Eisentraut wrote:
> Yeah but the new code already rejects those anyway.  Note how
> timestamptz_in() has explicit switch cases to accept those, and we
> didn't carry those over into check_recovery_time().

Ditto.  I was not paying much attention to the code.  Your patch
indeed rejects anything else than DTK_DATE.  So we are good here,
sorry for the noise.
--
Michael

Commits

  1. Don't call data type input functions in GUC check hooks