Horton

Re: BUG #15844: MIPS: remove .set mips2 in s_lock.h to fix r6 build

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: YunQiang Su <wzssyqa@gmail.com>, pgsql-bugs@lists.postgresql.org
Date: 2019-06-17T16:32:07Z
Lists: pgsql-bugs 
Hi,

On 2019-06-16 12:16:53 -0400, Tom Lane wrote:
> (We should not do anything if --disable-spinlocks has been specified,
> btw, since then we don't need those asm commands to work.  This is
> and would remain the workaround for building PG for MIPS-I, if some
> benighted soul insists on doing that.)

I think we're pretty much at the point where we should just rip out all
of our own spinlock implementations for non-common platforms, and solely
rely on compiler intrinsics... The open coded ASM really doesn't age
very well, and there's very little chance of us actually testing them
properly.

Greetings,

Andres Freund

Commits

  1. Fix spinlock assembly code for MIPS so it works on MIPS r6.