Re: tableam: abstracting relation sizing code

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Daniel Gustafsson <daniel@yesql.se>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-06-11T23:17:36Z
Lists: pgsql-hackers
Hi,

On 2019-06-10 15:35:18 -0400, Robert Haas wrote:
> On Fri, Jun 7, 2019 at 6:42 PM Daniel Gustafsson <daniel@yesql.se> wrote:
> > > Good catch, and now I notice that the callback is not called
> > > estimate_rel_size but relation_estimate_size.  Updated patch attached;
> > > thanks for the review.
> >
> > The commit message still refers to it as estimate_rel_size though. The comment on
> > table_block_relation_estimate_size does too but that one might be intentional.
> 
> Oops.  New version attached, hopefully fixing those and the compiler
> warning Alvaro noted.

Just to understand: What version are you targeting? It seems pretty
clearly v13 material to me?

Greetings,

Andres Freund



Commits

  1. tableam: Provide helper functions for relation sizing.