Horton

Re: be-gssapi-common.h should be located in src/include/libpq/

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>, Stephen Frost <sfrost@snowman.net>, Alvaro Herrera <alvherre@2ndquadrant.com>
Date: 2019-06-08T01:24:39Z
Lists: pgsql-hackers 
On Fri, Jun 07, 2019 at 09:52:26AM +0200, Daniel Gustafsson wrote:
> While looking at libpq.h I noticed what seems to be a few nitpicks: the GSS
> function prototype isn’t using the common format of having a comment specifying
> the file it belongs to; ssl_loaded_verify_locations is defined as extern even
> though it’s only available under USE_SSL (which works fine since it’s only
> accessed under USE_SSL but seems kinda wrong); and FeBeWaitSet is not listed
> under the pqcomm.c prototypes like how the extern vars from be-secure.c are.
> All of these are in the attached.

Indeed, this makes the header more consistent.  Thanks for noticing.
--
Michael

Commits

  1. Switch position of some declarations in libpq.h

  2. Move be-gssapi-common.h into src/include/libpq/