Re: be-gssapi-common.h should be located in src/include/libpq/

Stephen Frost <sfrost@snowman.net>

From: Stephen Frost <sfrost@snowman.net>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>, Alvaro Herrera <alvherre@2ndquadrant.com>
Date: 2019-06-07T12:11:07Z
Lists: pgsql-hackers
Greetings,

* Michael Paquier (michael@paquier.xyz) wrote:
> As mentioned on another thread about test coverage, I have noticed
> that be-gssapi-common.h is not placed at the correct location, even
> its its identication path at the top points to where the file should
> be:
> https://www.postgresql.org/message-id/20190604014630.GH1529@paquier.xyz
> 
> The file has been introduced at its current location as of b0b39f72.
> Any objections to something like the attached?

I'm pretty sure it ended up there just because that's how things are in
src/interfaces/libpq.  I don't have any objection to moving it, I had
really just been waiting to see where that thread ended up going.

On a quick look, the patch looks fine to me.

Thanks,

Stephen

Commits

  1. Switch position of some declarations in libpq.h

  2. Move be-gssapi-common.h into src/include/libpq/