Horton

Re: Custom table AMs need to include heapam.h because of BulkInsertState

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-06-01T19:55:05Z
Lists: pgsql-hackers 
On Sat, Jun 01, 2019 at 12:19:43PM -0700, Andres Freund wrote:
> Yea, I think we should do that at some point. But I'm not sure this is
> the right design. Bulk insert probably needs to rather be something
> that's allocated inside the AM.

Yeah, actually you may be right that I am not taking the correct path
here.  At quick glance it looks that there is a strong relationship
between the finish_bulk_insert callback and the bistate free already,
so we could do much better than moving the code around.  Perhaps we
could just have a TODO?  As one of the likely-doable items.
--
Michael

Commits

  1. Fix missing calls to table_finish_bulk_insert during COPY, take 2

  2. Fix missing call to table_finish_bulk_insert during COPY