Re: Why does pg_checksums -r not have a long option?
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Michael Banck <michael.banck@credativ.de>
Cc: Daniel Gustafsson <daniel@yesql.se>, Fabien COELHO <coelho@cri.ensmp.fr>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2019-05-28T02:56:48Z
Lists: pgsql-hackers
On Mon, May 27, 2019 at 10:17:43AM +0200, Michael Banck wrote: > Before we switch to -f out of consistency with oid2name, we should > consider Magnus' argument from > CABUevEzoeXaxbcYmMZsNF1aqdCwovys7-ChqCuGRY5+nsQZFew@mail.gmail.com IMO: > > |I have no problem with changing it to -r. -f seems a bit wrong to me, > |as it might read as a file. And in the future we might want to implement > |the ability to take full filename (with path), in which case it would > |make sense to use -f for that. You could also use a long option for that without a one-letter option, like --file-path or such, so reserving a one-letter option for a future, hypothetical use is not really a stopper in my opinion. In consequence, I think that that it is fine to just use -f/--filenode. Any objections or better suggestions from other folks here? -- Michael
Commits
-
Rework options of pg_checksums options for filenode handling
- fc115d0f9fc6 12.0 landed