Re: ACL dump ordering broken as well for tablespaces

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: "Bossart, Nathan" <bossartn@amazon.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>, Stephen Frost <sfrost@snowman.net>, "kommi.haribabu@gmail.com" <kommi.haribabu@gmail.com>
Date: 2019-05-23T01:51:18Z
Lists: pgsql-hackers
On Wed, May 22, 2019 at 06:35:31PM +0000, Bossart, Nathan wrote:
> The patch looks good to me.

Thanks for double-checking.  I have applied and back-patched.  The good
thing here is that there were zero conflicts.

> A bit of digging led me to the commit that removed databases and
> tablespaces from pg_init_privs [0] and to a related thread [1].  IIUC
> the problem is that using pg_init_privs for databases is complicated
> by the ability to drop and recreate the template databases.

I don't quite get this argument.  If a user is willing to drop
template1, then it is logic to also drop its initial privilege entries
and recreate new ones from scratch.  I think that this deserves a
closer lookup.  For tablespaces, we are limited by the ability of not
sharing pg_init_privs?
--
Michael

Commits

  1. Fix ordering of GRANT commands in pg_dumpall for tablespaces

  2. Correctly dump database and tablespace ACLs