Re: BUG #15804: Assertion failure when using logging_collector with EXEC_BACKEND
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Yuli Khodorkovskiy <yuli.khodorkovskiy@crunchydata.com>, pgsql-bugs@lists.postgresql.org
Date: 2019-05-19T00:43:45Z
Lists: pgsql-bugs
On Sat, May 18, 2019 at 12:18:28PM -0400, Tom Lane wrote: > At this point I agree with Michael that reverting 57431a911 is the most > prudent thing to do for beta1. While it's probably not *that* hard to > fix, it will require Windows-specific testing. Moreover, the fact that > there are race conditions involved means that one person's testing might > not catch everything. So I do not think we have enough time to get a > trustworthy fix in place by Monday. And we do have other things to > worry about. Thanks for confirming. There is little time for doing the revert, and it would have been nice seeing comments from Peter. Anyway, I should be able to do that myself in 24 hours or so after coming back in front of my desk so as the buildfarm can have a couple of cycles for its work. If you prefer doing that yourself, that's of course fine by me. > I wouldn't be totally opposed to un-reverting after beta1, if a > better-tested patch emerges. But we don't have such a patch today > and I don't see how we'll get there this weekend. Possible. My recommendation is to keep this as potential v13 work and focus on v12 stability. I have no doubt that after beta1 emerges we will get enough reports to work on. -- Michael
Commits
-
Rearrange postmaster's startup sequence for better syslogger results.
- 9a86f03b4e8c 13.0 landed
-
Improve logrotate test so that it meaningfully exercises syslogger.
- 9d5c22d28f8c 12.0 landed
-
Revert "postmaster: Start syslogger earlier".
- 833451552925 12.0 landed
-
postmaster: Start syslogger earlier
- 57431a911d3a 12.0 cited