Horton

Re: Inconsistent error message wording for REINDEX CONCURRENTLY

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2019-05-09T04:11:54Z
Lists: pgsql-hackers

Attachments

On Wed, May 08, 2019 at 11:28:35PM -0400, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
>> No problem to do that.  I'll brush up all that once you commit the
>> first piece you have come up with, and reuse the new API of catalog.c
>> you are introducing based on the table OID.
> 
> Pushed my stuff, have at it.

Thanks.  Attached is what I get to after scanning the error messages
in indexcmds.c and index.c.  Perhaps you have more comments about it?
--
Michael

Commits

  1. Rework some error strings for REINDEX CONCURRENTLY with system catalogs

  2. Improve and fix some error handling for REINDEX INDEX/TABLE CONCURRENTLY

  3. Clean up the behavior and API of catalog.c's is-catalog-relation tests.