Horton

Re: Statistical aggregate functions are not working with PARTIAL aggregation

Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>

View thread View on postgr.es
From: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
To: andrew.dunstan@2ndquadrant.com
Cc: stark@mit.edu, rajkumar.raghuwanshi@enterprisedb.com, pgsql-hackers@postgresql.org
Date: 2019-05-09T05:18:14Z
Lists: pgsql-hackers

Attachments

At Thu, 09 May 2019 11:17:46 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> wrote in <20190509.111746.217492977.horiguchi.kyotaro@lab.ntt.co.jp>
> Valgrind doesn't detect the overruning read since the block
> doesn't has 'MEMNOACCESS' region, since the requested size is
> just 64 bytes.
> 
> Thus the attached patch let valgrind detect the overrun.

So the attached patch makes palloc always attach the MEMNOACCESS
region and sentinel byte. The issue under discussion is detected
with this patch either. (But in return memory usage gets larger.)

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Commits

  1. Minimally fix partial aggregation for aggregates that don't have one argument.

  2. Change function call information to be variable length.