Horton

Re: Segfault when restoring -Fd dump on current HEAD

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Michael Paquier <michael@paquier.xyz>, Justin Pryzby <pryzby@telsasoft.com>, Hubert Lubaczewski <depesz@depesz.com>, pgsql-hackers mailing list <pgsql-hackers@postgresql.org>, Tomas Vondra <tomas.vondra@2ndquadrant.com>
Date: 2019-04-25T19:54:06Z
Lists: pgsql-hackers 
Hi,

On 2019-04-25 15:05:47 -0400, Alvaro Herrera wrote:
> On 2019-Mar-10, Dmitry Dolgov wrote:
> 
> > Then I guess we need to add the attached patch on top of a pg_dump support for
> > table am. It contains changes to use NULL as a default value for owner / defn /
> > dropStmt (exactly what we've changed back in 19455c9f56), and doesn't crash,
> > since K_VERS is different.
> 
> I think this is an open item; we were supposed to do it right after
> 3b925e905de3, but failed to notice.
> 
> Would anybody be too upset if I push this patch now?  CC'ed RMT.

I think that'd make sense. The rest of the RMT probably isn't awake
however, so I think it'd be good to give them 24h to object.

Greetings,

Andres Freund

Commits

  1. pg_dump: store unused attribs as NULL instead of '\0'

  2. pg_dump: Fix ArchiveEntry handling of some empty values