Horton

Re: pg_waldump and PREPARE

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2019-04-25T19:08:36Z
Lists: pgsql-hackers 
On 2019-Apr-26, Fujii Masao wrote:

> On Fri, Apr 26, 2019 at 1:04 AM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:

> >  I also wonder if
> > defining the structs in the way you do is the most sensible arrangement.
> 
> I did that arrangement because the format of PREPARE TRANSACTION record,
> i.e., that struct, also needs to be accessed in backend and frontend.
> But, of course, if there is smarter way, I'm happy to adopt that!

I don't know.  I spent some time staring at the code involved, and it
seems it'd be possible to improve just a little bit on cleanliness
grounds, with a lot of effort, but not enough practical value.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Fix comment in xact.h

  2. Make pg_waldump report more detail information about PREPARE TRANSACTION record.

  3. Store 2PC GID in commit/abort WAL recs for logical decoding