Re: Cleanup/remove/update references to OID column

Justin Pryzby <pryzby@telsasoft.com>

From: Justin Pryzby <pryzby@telsasoft.com>
To: Andres Freund <andres@anarazel.de>
Cc: Daniel Verite <daniel@manitou-mail.org>, pgsql-hackers@lists.postgresql.org
Date: 2019-04-18T04:14:13Z
Lists: pgsql-hackers
On Wed, Apr 17, 2019 at 05:51:15PM -0700, Andres Freund wrote:
> Hi,
> 
> On 2019-04-17 19:42:19 -0500, Justin Pryzby wrote:
> > diff --git a/doc/src/sgml/information_schema.sgml b/doc/src/sgml/information_schema.sgml
> > index 234a3bb..9c618b1 100644
> > --- a/doc/src/sgml/information_schema.sgml
> > +++ b/doc/src/sgml/information_schema.sgml
> > @@ -1312,8 +1312,8 @@
> >    <para>
> >     The view <literal>columns</literal> contains information about all
> >     table columns (or view columns) in the database.  System columns
> > -   (<literal>ctid</literal>, etc.) are not included.  Only those columns are
> > -   shown that the current user has access to (by way of being the
> > +   (<literal>ctid</literal>, etc.) are not included.  The only columns shown
> > +   are those to which the current user has access (by way of being the
> >     owner or having some privilege).
> >    </para>
> 
> I don't see the point of this change? Nor what it has to do with oids?

It doesn't have to do with oids, but seems more correct and cleaner...to my
eyes.

> > -   <replaceable>rows</replaceable> was exactly one and the target table was
> > +   <replaceable>count</replaceable> was exactly one and the target table was
> The <replacable>rows</<replacable> reference is from your change
> :(.

Ouch, not sure how I did that..sorry for the noise (twice).

Thanks,
Justin



Commits

  1. Doc: remove obsolete description of oid column as being "hidden".

  2. docs: Fix small copy & paste mistake.

  3. pg_dump: Remove stray option parsing support for -o.

  4. docs: cleanup/remove/update references to OID column.

  5. Adjust some more comments for WITH OIDS removal.

  6. Doc: remove obsolete statements about system OID columns in ALTER TABLE.