Horton

Re: Cleanup/remove/update references to OID column

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Daniel Verite <daniel@manitou-mail.org>
Cc: Michael Paquier <michael@paquier.xyz>, Justin Pryzby <pryzby@telsasoft.com>, pgsql-hackers@lists.postgresql.org
Date: 2019-04-18T00:29:59Z
Lists: pgsql-hackers 
Hi,

On 2019-04-15 18:35:12 +0200, Daniel Verite wrote:
> 	Andres Freund wrote:
> 
> > Yes, I was planning to commit that soon-ish. There still seemed
> > review / newer versions happening, though, so I was thinking of waiting
> > for a bit longer.
> 
> You might want to apply this trivial one in the same batch:
> 
> index 452f307..7cfb67f 100644
> --- a/src/bin/pg_dump/pg_dump.c
> +++ b/src/bin/pg_dump/pg_dump.c
> @@ -428,7 +428,7 @@ main(int argc, char **argv)
>  
> 	InitDumpOptions(&dopt);
>  
> -	while ((c = getopt_long(argc, argv,
> "abBcCd:E:f:F:h:j:n:N:oOp:RsS:t:T:U:vwWxZ:",
> +	while ((c = getopt_long(argc, argv,
> "abBcCd:E:f:F:h:j:n:N:Op:RsS:t:T:U:vwWxZ:",
> 							long_options,
> &optindex)) != -1)
> 	{
> 		switch (c)
> 
> "o" in the options list is a leftover. Leaving it in getopt_long() has the 
> effect that pg_dump -o fails (per the default case in the switch),
> but it's missing the expected error message (pg_dump: invalid option -- 'o')

Thanks for finding! Pushed.

Greetings,

Andres Freund

Commits

  1. Doc: remove obsolete description of oid column as being "hidden".

  2. docs: Fix small copy & paste mistake.

  3. pg_dump: Remove stray option parsing support for -o.

  4. docs: cleanup/remove/update references to OID column.

  5. Adjust some more comments for WITH OIDS removal.

  6. Doc: remove obsolete statements about system OID columns in ALTER TABLE.