Horton

Re: Suspicious strcmp() in src/backend/parser/parse_expr.c

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: David Rowley <david.rowley@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Andrew Gierth <andrew@tao11.riddles.org.uk>, Rikard Falkeborn <rikard.falkeborn@gmail.com>, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Date: 2019-04-12T01:29:54Z
Lists: pgsql-bugs 
On Fri, Apr 12, 2019 at 02:06:11AM +1200, David Rowley wrote:
> spell.c in NISortDictionary()
> 
> if (i == 0
> || strcmp(Conf->Spell[i]->p.flag, Conf->Spell[i - 1]->p.flag))
> 
> if (i == 0
> || strcmp(Conf->Spell[i]->p.flag, Conf->AffixData[curaffix]))

Good catch on these two.  I have included these and fixed all the
spots found in d527fda.
--
Michael

Commits

  1. Fix more strcmp() calls using boolean-like comparisons for result checks

  2. Fix backwards test in operator_precedence_warning logic.