Horton

Re: reloption to prevent VACUUM from truncating empty pages at the end of relation

Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>

View thread
From: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
To: masao.fujii@gmail.com
Cc: sawada.mshk@gmail.com, rjuju123@gmail.com, tsunakawa.takay@jp.fujitsu.com, alvherre@2ndquadrant.com, andres@anarazel.de, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, david@pgmasters.net, bossartn@amazon.com, andrew.dunstan@2ndquadrant.com, michael@paquier.xyz, laurenz.albe@cybertec.at, k.jamison@jp.fujitsu.com, amit.kapila16@gmail.com, pgsql-hackers@postgresql.org
Date: 2019-04-10T01:58:42Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add TRUNCATE parameter to VACUUM.

  2. Add vacuum_truncate reloption.

  3. Allow VACUUM to be run with index cleanup disabled.

At Wed, 10 Apr 2019 02:00:03 +0900, Fujii Masao <masao.fujii@gmail.com> wrote in <CAHGQGwGufa=f4RWAscOyz1J76Gs-u+wmUt6oZF8YswLiMF13Ew@mail.gmail.com>
> On Tue, Apr 9, 2019 at 1:07 PM Kyotaro HORIGUCHI
> <horiguchi.kyotaro@lab.ntt.co.jp> wrote:
> >
> > Hello.
> >
> > At Mon, 8 Apr 2019 19:22:04 +0900, Fujii Masao <masao.fujii@gmail.com> wrote in <CAHGQGwHa_dX=dRcbR5QVTs6W5mgCy3qZ2fEwREaiXpES1B2+jw@mail.gmail.com>
> > > > "TRUNCATE" option for vacuum command should be added to the open items?
> > >
> > > Yes, I think.
> > > Attached is the patch which adds TRUNCATE option into VACUUM.
> >
> > By the way, this might have been discussed upthread, but boolean
> > options of VACUUM command is defaulted to true. So, it seems to
> > me that the name is better (or convenient to me) to be
> > SKIP_TRUNCATE. The name of the reloption seems good to me.
> 
> If we really use SKIP_TRUNCATE, we need to use SKIP_INDEX_CLEANUP
> instead of INDEX_CLEANUP for the consistency. But TRUNCATE and
> INDEX_CLEANUP look more intuitive to me than SKIP_TRUNCATE and
> SKIP_INDEX_CLEANUP.

Ah, yes, we already have INDEX_CLEANUP. I'm fine with TRUNCATE.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center