Horton

Re: COPY FROM WHEN condition

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: David Rowley <david.rowley@2ndquadrant.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>, Surafel Temesgen <surafel3000@gmail.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Adam Berlin <berlin.ab@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Haribabu Kommi <kommi.haribabu@gmail.com>
Date: 2019-04-04T19:04:28Z
Lists: pgsql-hackers 
On 2019-04-03 22:20:00 -0700, Andres Freund wrote:
> Hi,
> 
> On 2019-04-03 20:00:09 +1300, David Rowley wrote:
> > Oops, I forgot about that one. v4 attached.
> 
> I'm pretty happy with this. I'm doing some minor changes (e.g. don't
> like the function comment formatting that much, the tableam callback
> needs docs, stuff like that), and then I'm going to push it tomorrow.

After another read, I also think I'm going to rename the functions a
bit. CopyMultiInsertInfo_SetupBuffer, with its mix of camel-case and
underscores, just doesn't seem to mix well with copy.c and also just
generally other postgres code. I feel we already have too many different
naming conventions...

Greetings,

Andres Freund

Commits

  1. Remove unused struct member, enforce multi_insert callback presence.

  2. Separate per-batch and per-tuple memory contexts in COPY

  3. Fix handling of volatile expressions in COPY FROM ... WHERE

  4. Allow COPY FROM to filter data using WHERE conditions

  5. Remove obsolete netbsd dynloader code