Horton

Re: Progress reporting for pg_verify_checksums

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Michael Banck <michael.banck@credativ.de>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>, Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>, alvherre@2ndquadrant.com, mailings@oopsware.de, thomas.munro@enterprisedb.com, pgsql-hackers@postgresql.org
Date: 2019-04-02T02:05:56Z
Lists: pgsql-hackers 
On Mon, Apr 01, 2019 at 08:51:03PM +0200, Michael Banck wrote:
> I had another look and I don't see any slowdown with your patch.

I noticed one slowdown when using --disable --progress as this was
scanning the data directory for the total size but we don't need it in
this case.  Fixed that and committed.
--
Michael

Commits

  1. Add progress reporting to pg_checksums

  2. Fix thinko when bumping on temporary directories in pg_verify_checksums

  3. Fix thinko when bumping on temporary directories in pg_checksums