Horton

Re: Extending USE_MODULE_DB to more test suite types

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Noah Misch <noah@leadboat.com>
Cc: pgsql-hackers@postgresql.org
Date: 2019-04-01T17:06:58Z
Lists: pgsql-hackers 
On 2019-04-01 06:52:13 -0700, Noah Misch wrote:
> I plan to back-patch the PostgreSQL patch, to combat buildfarm noise.  Perhaps
> someone has test automation that sets USE_MODULE_DB and nonetheless probes the
> exact database name "pl_regression", but I'm not too worried.  The original
> rationale for USE_MODULE_DB, in commit ad69bd0, was to facilitate pg_upgrade
> testing.  Folks using "make installcheck-world" to populate a cluster for
> pg_upgrade testing will see additional test coverage, which may cause
> additional failures.  I'm fine with that, too.

+1 for all of that.

Greetings,

Andres Freund

Commits

  1. Handle USE_MODULE_DB for all tests able to use an installed postmaster.

  2. Add mode where contrib installcheck runs each module in a separately named database.