Re: Tab completion for ALTER INDEX|TABLE ALTER COLUMN SET STATISTICS
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Tatsuro Yamada <yamada.tatsuro@lab.ntt.co.jp>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>, pgsql-hackers@lists.postgresql.org
Date: 2018-12-25T05:27:03Z
Lists: pgsql-hackers
On Tue, Dec 25, 2018 at 10:56:04AM +0900, Tatsuro Yamada wrote: > Hmm... Okey, I agree. Why I implemented the exotic part of the > feature is that it is for user-friendly. However, I suppose that > user know the syntax because the syntax is used by an expert user. Thanks, I have committed this one after making the logic to ignore column numbers a bit smarter, one problem being that "ALTER INDEX foo ALTER COLUMN" would try to suggest SET STATISTICS directly, which is incorrect. Instead I have tweaked the completion so as COLUMN is added after "ALTER INDEX foo ALTER". This could be completed later with the column numbers, in a way similar to what ALTER TABLE does. -- Michael
Commits
-
Improve tab completion of ALTER INDEX/TABLE with SET STATISTICS in psql
- f89ae34ab8b4 12.0 landed
-
Prioritize history files when archiving
- b981df4cc09a 12.0 cited