Horton

Thread

Commits

  1. Improve description of DEFAULT_XLOG_SEG_SIZE in pg_config.h

  1. Minor comment fix for pg_config_manual.h

    Ian Barwick <ian.barwick@2ndquadrant.com> — 2018-12-24T04:05:25Z

    Hi

Attached is mainly to fix a comment in $subject which has a typo in the referenced initdb
option ("--walsegsize", should be "--wal-segsize"), and while I'm there also adds a
couple of "the" for readability.


Regards

Ian Barwick

-- 
  Ian Barwick                   http://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services

  2. Re: Minor comment fix for pg_config_manual.h

    Michael Paquier <michael@paquier.xyz> — 2018-12-24T08:57:26Z

    On Mon, Dec 24, 2018 at 01:05:25PM +0900, Ian Barwick wrote:
> Attached is mainly to fix a comment in $subject which has a typo in
> the referenced initdb option ("--walsegsize", should be
> "--wal-segsize"), and while I'm there also adds a couple of "the"
> for readability.

All that (the error as well as the extra "the" for clarity in this
sentence) seems right to me.  Any opinions from others?
--
Michael

  3. Re: Minor comment fix for pg_config_manual.h

    Tom Lane <tgl@sss.pgh.pa.us> — 2018-12-25T15:22:30Z

    Michael Paquier <michael@paquier.xyz> writes:
> On Mon, Dec 24, 2018 at 01:05:25PM +0900, Ian Barwick wrote:
>> Attached is mainly to fix a comment in $subject which has a typo in
>> the referenced initdb option ("--walsegsize", should be
>> "--wal-segsize"), and while I'm there also adds a couple of "the"
>> for readability.

> All that (the error as well as the extra "the" for clarity in this
> sentence) seems right to me.  Any opinions from others?

The text still seems a bit awkward.  Maybe "... to be used when initdb
is run without the ..."

			regards, tom lane

  4. Re: Minor comment fix for pg_config_manual.h

    Michael Paquier <michael@paquier.xyz> — 2018-12-26T00:36:57Z

    On Tue, Dec 25, 2018 at 10:22:30AM -0500, Tom Lane wrote:
> The text still seems a bit awkward.  Maybe "... to be used when initdb
> is run without the ..."

like the attached perhaps?  At the same time I am thinking about
reformulating the second sentence as well..
--
Michael

  5. Re: Minor comment fix for pg_config_manual.h

    Michael Paquier <michael@paquier.xyz> — 2018-12-28T01:41:43Z

    On Wed, Dec 26, 2018 at 09:36:57AM +0900, Michael Paquier wrote:
> like the attached perhaps?  At the same time I am thinking about
> reformulating the second sentence as well..
>
>  /*
> - * This is default value for wal_segment_size to be used at initdb when run
> - * without --walsegsize option. Must be a valid segment size.
> + * This is the default value for wal_segment_size to be used when initdb is run
> + * without the --wal-segsize option.  It must be a valid segment size.
>   */
>  #define DEFAULT_XLOG_SEG_SIZE	(16*1024*1024)

So, any objections with this change?  If somebody has a better
wording, please feel free to chime in.
--
Michael

  6. Re: Minor comment fix for pg_config_manual.h

    Alvaro Herrera <alvherre@2ndquadrant.com> — 2018-12-28T03:37:41Z

    On 2018-Dec-28, Michael Paquier wrote:

> On Wed, Dec 26, 2018 at 09:36:57AM +0900, Michael Paquier wrote:
> > like the attached perhaps?  At the same time I am thinking about
> > reformulating the second sentence as well..
> >
> >  /*
> > - * This is default value for wal_segment_size to be used at initdb when run
> > - * without --walsegsize option. Must be a valid segment size.
> > + * This is the default value for wal_segment_size to be used when initdb is run
> > + * without the --wal-segsize option.  It must be a valid segment size.
> >   */
> >  #define DEFAULT_XLOG_SEG_SIZE	(16*1024*1024)
> 
> So, any objections with this change?  If somebody has a better
> wording, please feel free to chime in.

Looks good to me.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

  7. Re: Minor comment fix for pg_config_manual.h

    Michael Paquier <michael@paquier.xyz> — 2018-12-28T23:27:16Z

    On Fri, Dec 28, 2018 at 12:37:41AM -0300, Alvaro Herrera wrote:
> Looks good to me.

Thanks for the lookup.  I have committed and back-patched to v11 for
consistency.
--
Michael

  8. Re: Minor comment fix for pg_config_manual.h

    Ian Barwick <ian.barwick@2ndquadrant.com> — 2018-12-31T00:50:29Z

    On 12/29/18 8:27 AM, Michael Paquier wrote:
> On Fri, Dec 28, 2018 at 12:37:41AM -0300, Alvaro Herrera wrote:
>> Looks good to me.
> 
> Thanks for the lookup.  I have committed and back-patched to v11 for
> consistency.

Thanks!


Regards

Ian Barwick


-- 
  Ian Barwick                   http://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services