Re: Change pgarch_readyXlog() to return .history files first
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: David Steele <david@pgmasters.net>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>, pgsql-hackers@postgresql.org
Date: 2018-12-21T23:55:14Z
Lists: pgsql-hackers
On Fri, Dec 21, 2018 at 08:17:12AM +0200, David Steele wrote: > I thought about doing that, but wanted to focus on the task at hand. It > does save a strcpy and a bit of stack space, so seems like a win. > > Overall, the patch looks good to me. I think breaking up the if does make > the code more readable. Thanks for the lookups. I can see that the patch applies without conflicts down to 9.4, and based on the opinions gathered on this thread back-patching this stuff is the consensus, based on input from Kyotaro Horiguchi and David Steele (I don't mind much myself). So, any objections from others in doing so? -- Michael
Commits
-
Prioritize history files when archiving
- 37126251ab77 9.5.16 landed
- 9378701243b5 9.6.12 landed
- 0857575774a2 10.7 landed
- a016f59d5901 11.2 landed
- b981df4cc09a 12.0 landed