Re: Tab completion for ALTER INDEX|TABLE ALTER COLUMN SET STATISTICS
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Tatsuro Yamada <yamada.tatsuro@lab.ntt.co.jp>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>, pgsql-hackers@lists.postgresql.org
Date: 2018-12-19T09:22:55Z
Lists: pgsql-hackers
On Wed, Dec 19, 2018 at 04:26:27PM +0900, Tatsuro Yamada wrote:
> Yep, I already did that for ALTER INDEX in tab_completion_alter_index_set_statistics.patch like this:
>
> + /* ALTER INDEX <name> ALTER COLUMN <colname> SET STATISTICS */
> + else if (HeadMatches("ALTER", "INDEX") && TailMatches("SET", "STATISTICS")){
> + /* We don't complete after "SET STATISTICS" */
> + }
[Wake up, Neo]
Okay, then I propose to first extract a patch which does the following
things as a first step to simplify the follow-up work:
- No completion after "ALTER TABLE/INDEX SET STATISTICS" instead of
schemas.
- Complete "ALTER INDEX foo ALTER COLUMN SET" with STATISTICS (now this
prints parameters, which is annoying).
Then let's figure out the details for the rest.
--
Michael
Commits
-
Improve tab completion of ALTER INDEX/TABLE with SET STATISTICS in psql
- f89ae34ab8b4 12.0 landed
-
Prioritize history files when archiving
- b981df4cc09a 12.0 cited