Horton

Re: BUG #15552: Unexpected error in COPY to a foreign table in a transaction

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>, Luis Carril <luis.carril@swarm64.com>, "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>, PG Bug reporting form <noreply@postgresql.org>, Michael Paquier <michael.paquier@gmail.com>
Date: 2018-12-19T09:13:25Z
Lists: pgsql-bugs 
On Wed, Dec 19, 2018 at 05:34:22PM +0900, Michael Paquier wrote:
> On Wed, Dec 19, 2018 at 04:49:19PM +0900, Etsuro Fujita wrote:
>> BTW I noticed that this error occurs not only for foreign tables but for
>> views with INSTEAD OF INSERT triggers.  Here is an example on HEAD:
>> 
>> To fix this I think we would also need the same treatment for the view case.
> 
> Yes, this means an extra relkind check for views.  Would you like to
> update the patch yourself?

While I still have that stuff in mind, for a patch on HEAD we could just
use RELKIND_CAN_HAVE_STORAGE() as additional check and also remove the
check on RELKIND_PARTITIONED_TABLE.  And just add a check on
RELKIND_VIEW for back-branches on top of what's already present.  If you
would like to write a new patch, please feel free to.  Or I am fine to
do it myself.
--
Michael

Commits

  1. Disable WAL-skipping optimization for COPY on views

  2. Disable WAL-skipping optimization for COPY on views and foreign tables