Re: Should new partitions inherit their tablespace from their parent?

Alvaro Herrera <alvherre@2ndquadrant.com>

From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: David Rowley <david.rowley@2ndquadrant.com>, Robert Haas <robertmhaas@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2018-12-18T01:13:42Z
Lists: pgsql-hackers
On 2018-Dec-18, Michael Paquier wrote:

> On Tue, Dec 18, 2018 at 09:36:17AM +1300, David Rowley wrote:
> > On Tue, 18 Dec 2018 at 08:21, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> >> Pushed with those changes.  Thanks for the patch!
> > 
> > Thanks for committing it and thanks for reviewing it, Michael.
> 
> Perhaps too early to speak, tests of sepgsql are broken after this
> commit as per rhinoceros report:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=rhinoceros&dt=2018-12-18%2000%3A45%3A01

Ah, thanks.

I think we need to accept the new output.  It is saying that previously
we would not invoke the hook on SET TABLESPACE for a partitioned table,
which makes sense, and now we do invoke it, which also makes sense.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


Commits

  1. Fix tablespace handling for partitioned tables