Re: Why aren't we using strsignal(3) ?

Alvaro Herrera <alvherre@2ndquadrant.com>

From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2018-12-17T17:03:29Z
Lists: pgsql-hackers
On 2018-Dec-17, Tom Lane wrote:

> But it looks like
> we could drop the sys_siglist support for an undetectably small penalty:
> even if, somewhere, there's a platform that has sys_siglist[] but not
> strsignal(), it'd just mean that you get only a signal number and have
> to look up its meaning.
> 
> While a dozen lines in pgstrsignal.c certainly are not worth worrying
> over, getting rid of the configure test for sys_siglist[] would save
> some cycles on every build.  So I'm tempted to drop it.  Thoughts?

+1 for nuking it.  configure times grow larger, and there's seldom a
change to make them shorter.  In this case, per your analysis, it
doesn't look like we're losing anything worthwhile.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


Commits

  1. Drop support for getting signal descriptions from sys_siglist[].

  2. Modernize our code for looking up descriptive strings for Unix signals.