Horton

Re: automatically assigning catalog toast oids

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Stephen Frost <sfrost@snowman.net>, John Naylor <jcnaylor@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2018-12-15T02:01:59Z
Lists: pgsql-hackers 
Hi,

On 2018-12-14 22:54:14 -0300, Alvaro Herrera wrote:
> On 2018-Dec-13, Tom Lane wrote:
> > Looking at the existing entries, it seems like we'd have to have
> > one special case: schema public has OID 2200 but is intentionally
> > not pinned.  I wouldn't have a hard time with teaching isObjectPinned
> > about that; though if it turns out that many places need to know
> > about it, maybe it's not workable.
> 
> Why not just move that OID outside the Genbki special range?  I have
> seen quite a few installs where schema public was removed and later
> re-added.  I've never seen a query hardcode OID 2200, and I'd call one
> which does buggy.

+1

Greetings,

Andres Freund

Commits

  1. Fix typo in transam.h for OIDs assigned by genbki.pl

  2. Create a separate oid range for oids assigned by genbki.pl.

  3. Remove WITH OIDS support, change oid catalog column visibility.

  4. Add toast tables to most system catalogs