Re: automatically assigning catalog toast oids
Alvaro Herrera <alvherre@2ndquadrant.com>
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, Stephen Frost <sfrost@snowman.net>, John Naylor <jcnaylor@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2018-12-15T01:54:14Z
Lists: pgsql-hackers
On 2018-Dec-13, Tom Lane wrote: > We could take it a bit further and not make the 'p' entries for such > OIDs in the first place, greatly reducing the size of pg_depend in > typical installations. Perhaps that'd confuse clients that look at > that catalog, though. The number of 'p' entries in pg_depend is often annoying when manually querying it. I support the idea of special-casing such entries. > Looking at the existing entries, it seems like we'd have to have > one special case: schema public has OID 2200 but is intentionally > not pinned. I wouldn't have a hard time with teaching isObjectPinned > about that; though if it turns out that many places need to know > about it, maybe it's not workable. Why not just move that OID outside the Genbki special range? I have seen quite a few installs where schema public was removed and later re-added. I've never seen a query hardcode OID 2200, and I'd call one which does buggy. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Fix typo in transam.h for OIDs assigned by genbki.pl
- f0cce9fcb5fd 12.0 landed
-
Create a separate oid range for oids assigned by genbki.pl.
- 09568ec3d31b 12.0 landed
-
Remove WITH OIDS support, change oid catalog column visibility.
- 578b229718e8 12.0 cited
-
Add toast tables to most system catalogs
- 96cdeae07f93 12.0 cited