Re: Ryu floating point output patch
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>, Thomas Munro <thomas.munro@enterprisedb.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2018-12-14T18:29:22Z
Lists: pgsql-hackers
Hi, On 2018-12-14 13:25:29 -0500, Tom Lane wrote: > Our track record in borrowing code from "upstream" projects is pretty > miserable: almost without exception, we've found ourselves stuck with > maintaining such code ourselves after a few years. I don't see any > reason to think that wouldn't be true here; in fact there's much more > reason to worry here than we had for, eg, borrowing the regex code. > The maintenance track record of this github repo appears to span six > months, and it's now been about four months since the last commit. > It might be abandonware already. It's been absorbed into MSVC's standard library and a bunch of other projects, so there's certainly some other prominent adoption. The last commit was a month ago, no? November 6th afaict. > Is this a path we really want to go down? I'm not convinced the > cost/benefit ratio is attractive. float->text conversion is one of the major bottlenecks when backing up postgres, it's definitely a pain-point in practice. I've not really seen a nicer implementation anywhere, not even close. Greetings, Andres Freund
Commits
-
Provide an extra-float-digits setting for pg_dump / pg_dumpall
- af25bc03e17e 12.0 landed
-
Change floating-point output format for improved performance.
- 02ddd499322a 12.0 landed
-
Use strtof() and not strtod() for float4 input.
- f397e08599a3 12.0 landed