Re: Add pg_partition_root to get top-most parent of a partition tree
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Postgres hackers <pgsql-hackers@postgresql.org>, Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Date: 2018-12-12T01:48:25Z
Lists: pgsql-hackers
Attachments
- partition-root-v2.patch (text/x-diff) patch v2
On Fri, Dec 07, 2018 at 11:46:05AM +0900, Michael Paquier wrote: > On Thu, Dec 06, 2018 at 10:48:59PM -0300, Alvaro Herrera wrote: >> I think adding a pg_partition_root() call to as many pg_partition_tree >> tests as you modified is overkill ... OTOH I'd have one test that >> invokes pg_partition_tree(pg_partition_root(some-partition)) to verify >> that starting from any point in the tree you get the whole tree. > > Good idea, thanks for the input. The recent commit cc53123 has fixed a couple of issues with pg_partition_tree, so attached is a rebased patch which similarly makes pg_partition_root return NULL for unsupported relkinds and undefined relations. I have also simplified the tests based on Alvaro's suggestion to use pg_partition_tree(pg_partition_root(partfoo)). Thanks, -- Michael
Commits
-
Add pg_partition_root to display top-most parent of a partition tree
- 3677a0b26bb2 12.0 landed
-
Tweak pg_partition_tree for undefined relations and unsupported relkinds
- cc53123bcc9d 12.0 cited