Horton

Re: automatically assigning catalog toast oids

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: John Naylor <jcnaylor@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Stephen Frost <sfrost@snowman.net>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2018-12-12T00:44:29Z
Lists: pgsql-hackers 
Hi,

On 2018-12-11 19:33:23 -0500, John Naylor wrote:
> On 12/11/18, Andres Freund <andres@anarazel.de> wrote:
> > I've attached a patch implementing that.  I'm not particularly in love
> > with FirstGenbkiObjectId as the symbol, but I couldn't think of
> > something more descriptive.
> 
> How about FirstAutoAssignedObjectId?

That sounds too general to me. Could just as well be what
FirstNormalObjectId is, or what FirstBootstrapObjectId is. So between
those I do prefer FirstGenbkiObjectId, as that's clearer.  Could go for
FirstGenbkiAssignedObjectId too, but that's probably a bit redundant.

Greetings,

Andres Freund

Commits

  1. Fix typo in transam.h for OIDs assigned by genbki.pl

  2. Create a separate oid range for oids assigned by genbki.pl.

  3. Remove WITH OIDS support, change oid catalog column visibility.

  4. Add toast tables to most system catalogs