Horton

Re: automatically assigning catalog toast oids

Stephen Frost <sfrost@snowman.net>

View thread View on postgr.es
From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: John Naylor <jcnaylor@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2018-12-09T20:42:57Z
Lists: pgsql-hackers 
Greetings,

* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> John Naylor <jcnaylor@gmail.com> writes:
> > Commit 96cdeae07 added toast tables to most catalogs. One disadvantage
> > is that the toast declarations require hard-coded oids, even though
> > only shared catalogs actually need stable oids. Now that we can assign
> > oids on the fly, it makes sense to do so for toast tables as well, as
> > in the attached.
> 
> I'm a bit dubious that this is a good idea.  It's handy, at least for
> forensic situations, that the system catalogs have stable OIDs.

I tend to agree...  What's the advantage of assigning them on the fly?

Thanks!

Stephen

Commits

  1. Fix typo in transam.h for OIDs assigned by genbki.pl

  2. Create a separate oid range for oids assigned by genbki.pl.

  3. Remove WITH OIDS support, change oid catalog column visibility.

  4. Add toast tables to most system catalogs